Update profileBuilder to delete profile contents before generating.#1095
Merged
Update profileBuilder to delete profile contents before generating.#1095
Conversation
This allows a cross-platform option to safely delete profile packages before generating. This makes it easier to ensure that if a package is deleted from a list definition of a profile, it gets deleted on the file system as well.
ghost
added
the
Member
Author
|
Once this is merged into |
lmazuel
approved these changes
Feb 15, 2018
| ], | ||
| "autorest_options": { | ||
| "use": "@microsoft.azure/autorest.go@preview", | ||
| "use": "@microsoft.azure/autorest.go@2.1.86", |
Member
There was a problem hiding this comment.
There is a npm syntax to say "latest of the 2.x series" if you want.
https://docs.npmjs.com/misc/semver#x-ranges-12x-1x-12-
Because Autorest gives that to npm directly, and doesn't look at what you actually write.
Member
Author
There was a problem hiding this comment.
Updated! Thanks for the tip
Member
Author
There was a problem hiding this comment.
For posterity, I tested the syntax to use with this command:
npm show "@microsoft.azure/autorest.go@~2" version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1066
Long-term, I'd like to separate out the logic for latest into a separate tool, as I mention in the thread associated with #1066. However, for now, I'd like to just get out what we need to in order to publish profiles correctly most expediently.